Updates to TivoWeb / TivoWebPlus

[Teepee]

Good suggestion swuk, the forum's looking better already

[Nimbus]

I've never done this before, but...
User Control Panel -> Friends & Foes -> Manage Foes -> Add new Foes -> enter troll's name -> Submit.
Back to forum... much better.

I'm not suggesting that or asking anyone else to do this. Just relaying what I've done.

Thanks swuk, I'd been looking for how to do that for ages, and it was right under my nose all the time...

[fizz]

do we have to apply all these patches or is there just a 'service pack' with all of them up to now?

[mrtickle]

I'm getting this on a tivo which is testing our tmsids in the data

Code: Select all

-------INTERNAL SERVER ERROR------  --cut here--action:series, path:/422378/-1, env:, code:'NONE'
can't read "l3": no such variable
    while executing
"foreach {fsid name type} $l3 {
RetryTransaction {
set oldrec [db $::db openid $fsid]
set showing [dbobj $oldrec get Showing]
set program [dbobj $showi..."
    (procedure "MOD::action_series" line 71)
    invoked from: "$cmd $chan $path $env"
--cut here--


in ui_series line 59 there is this

Code: Select all

elseif {$hastms} {
      set l [getFsidsByPrefix /Recording/TmsId $TmsId 6]
      if [PrefixMatches "SH" $TmsId] {
        set l [concat $l [getFsidsByPrefix /Recording/TmsId EP[string range $TmsId 2 end] 6]]
      }
    } else {
  (everyone else with tmsids)
  (code which sets l and l3)


So "l3" is never set on a tmsid-altepg-tivo, but it's used below in line 90.

[spitfires]

Oops

try changing L90-103 with

Code: Select all

   if [info exists l3] {
      foreach {fsid name type} $l3 {
         RetryTransaction {
            # puts fsid=$fsid
            set oldrec [db $::db openid $fsid]
            set showing [dbobj $oldrec get Showing]
            set program [dbobj $showing get Program]
            set orphantitle [strim [dbobj $program get Title]]      
            if { [PrefixMatches $Title $orphantitle] } {      
               # puts "match=$Title ++++++ $orphantitle"
               set l [concat $l $fsid $name $type]
            }   
         }   
         #puts "ids: $l"
      }
   }

(i.e. surround the foreach with a test for existence)

[mrtickle]

that's sorted it, thanks!

[mrtickle]

In addition to the change above, required for TmsId support, there is a further change to ui_showing which was made just before xmas. This is necessary to handle middle names in quotes. TiVoweb bombed on the actor {Snyder|Jimmy "The Greek"} which was from Tribune data, and Dirty Dancing on Boxing day contained the actor "Cousin Brucie" Morrow .

This updated version of PrintNames fixes the latest problem.

Code: Select all

proc PrintNames  {args} {
  set str ""
  set names [lindex $args 0]
  set searchtype 0
  if { [llength $args] > 1} {
    set searchtype [lindex $args 1]
    set searchby [lindex "4 5" [expr $searchtype - 1]]
  }
  foreach name $names {
    # [spitfires] [fix for AltEPG actors/directors names format]  amended 20111222 to handle middle names in quotes
      if { [regexp {(.*)\|(.*)} $name junk last first] } {
         set nameformat 1
         set str1 [string trim "$first $last"]
      } elseif { [regexp {(.*) (.*)} $name junk first last] } {
         set nameformat 2
         set str1 "$first $last"
      } else {
         set first ""
         set last $name
         set nameformat 3
         set str1 $name
      }
      if { [info exists nameformat ] } {
      if { $searchtype > 0 } {
        if {$first == ""} {
          set str2 [httpMapReply "$last\t"]
        } else {
         # [spitfires] [fix for AltEPG actors/directors names format]
         if {$nameformat == 1} {
            set str2 [httpMapReply "$last, $first\t"]
         } else {
            set str2 [httpMapReply "$first $last\t"]
         }
        }
        set str1 [html_link "/search?searchby=$searchby&q=$str2" $str1]
      }
      if { $str == "" } {
        set str $str1
      } else {
        append str ", $str1"
      }
    }
  }
  return $str
}

I have today made a "rollup" of all the patches from this thread applied in sequence, including these last two. (The dates on some files may be today's, but I'm naming it by the date of the last patch). Here it is:

2011-12-22-tw2-patches-rollup.tar

TivoWebPlus21b3 patches rollup 1

(98.5 KiB) Downloaded 211 times

[JDW]

I expect I am being totally dumb, but I think I have read this thread throughout and maybe missed it. How do I apply the rolled up patch? If I missed it please point me to the instructions - thanks,

John